Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final updates for merge #252

Merged
merged 6 commits into from
Aug 15, 2022
Merged

Final updates for merge #252

merged 6 commits into from
Aug 15, 2022

Conversation

BernieWhite
Copy link
Contributor

Overview/Summary

Clean ups for merging to main.

Related to #206

This PR fixes/adds/changes/removes

  1. Added additional comments and references.
  2. Added suppression group for bastion public IP.
  3. Added tag on Bastion public IP for suppression group and later rule exclusion.

Testing Evidence

Tested locally with PSRule.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 27, 2022
@BernieWhite BernieWhite marked this pull request as ready for review May 27, 2022 14:19
@BernieWhite
Copy link
Contributor Author

@jtracey93 This should be good to go. Let me know if there is any further updates required.

@jtracey93 jtracey93 added hygiene and removed Needs: Triage 🔍 Needs triaging by the team labels Jun 16, 2022
@BernieWhite BernieWhite marked this pull request as draft August 11, 2022 12:19
@olljanat olljanat mentioned this pull request Aug 11, 2022
Closed
10 tasks
@BernieWhite
Copy link
Contributor Author

@jtracey93 Ready for final review and merge.

@BernieWhite BernieWhite marked this pull request as ready for review August 14, 2022 02:43
@jtracey93
Copy link
Contributor

Thanks @BernieWhite

@jtracey93 jtracey93 merged commit 113e433 into Azure:ps-rule Aug 15, 2022
@BernieWhite BernieWhite deleted the bewhite/final-updates branch August 15, 2022 03:43
jtracey93 added a commit that referenced this pull request Sep 5, 2022
@jtracey93 @BernieWhite
Add PSRule To ALZ Bicep Testing (#313)
2120863 
* Initial PSRule without parameter files #206 (#207)

* Initial PSRule without parameter files #206

* Update triggers and reference extension

* Separate job to ignore build bicep code

* Update PSRule options to include Bicep samples

* PSRule baseline and minium samples (#236)

* Update exclusions and complete AZ params for PIPs (#242)

* Update exclusions and complete AZ params for PIPs

* Add additional comments

* Final updates for merge (#252)

* psrule sample fixes

* fix github linter for PSRule MD

* typo fix

* update rules

Co-authored-by: Bernie White <bewhite@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BernieWhite @jtracey93